Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples and readme for Content Safety sdk #36784

Merged
merged 14 commits into from
Jun 6, 2023
Merged

Update samples and readme for Content Safety sdk #36784

merged 14 commits into from
Jun 6, 2023

Conversation

mengaims
Copy link
Contributor

@mengaims mengaims commented Jun 1, 2023

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@mengaims
Copy link
Contributor Author

mengaims commented Jun 1, 2023

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mengaims
Copy link
Contributor Author

mengaims commented Jun 1, 2023

/azp run net - contentsafety - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mengaims mengaims marked this pull request as ready for review June 1, 2023 16:57
@mengaims
Copy link
Contributor Author

mengaims commented Jun 1, 2023

@heaths I've added the readme and refine samples for Content Safety in this PR, could you help review?

@mengaims mengaims requested a review from heaths June 1, 2023 17:06
heaths
heaths requested changes Jun 1, 2023
View reviewed changes
sdk/contentsafety/Azure.AI.ContentSafety/CHANGELOG.md Show resolved Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/README.md Outdated Show resolved Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/README.md Outdated Show resolved Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/README.md Outdated Show resolved Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/README.md Outdated Show resolved Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/README.md Outdated Show resolved Hide resolved
@pallavit
Copy link
Contributor

pallavit commented Jun 1, 2023

Can we please include the SDK in the codeowners file - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS

@mengaims
Copy link
Contributor Author

mengaims commented Jun 2, 2023

Can we please include the SDK in the codeowners file - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS

Already added in previous PR: #34933

@mengaims
Copy link
Contributor Author

mengaims commented Jun 2, 2023 •
edited
Loading

@heaths I've reply all the comments, please help check and approve, thanks!

heaths
heaths requested changes Jun 2, 2023
View reviewed changes
Copy link
Member

@heaths heaths left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run eng/scripts/CodeChecks.ps1 contentsafety to make sure everything is updated.

Actually, I see now why the build didn't fail like it should've: you need to add a package-level "samples" with markdown files that reference the snippets. See https://github.com/Azure/azure-sdk-for-net/blob/main/samples/README.MD.

@mengaims
Copy link
Contributor Author

mengaims commented Jun 5, 2023

You need to run eng/scripts/CodeChecks.ps1 contentsafety to make sure everything is updated.

Actually, I see now why the build didn't fail like it should've: you need to add a package-level "samples" with markdown files that reference the snippets. See https://github.com/Azure/azure-sdk-for-net/blob/main/samples/README.MD.

Hi @heaths , I've added a package-level "samples", please check.
And I've also ran eng/scripts/CodeChecks.ps1 contentsafety locally, it's wired that it always report following error:

error : Missing project. Solution references a project which does not exist: D:\src\mengaims\azure-sdk-for-net\sdk\contentsafety\Azure.AI.ContentSafety\项目. [D:\src\mengaims\azure-sdk-for-net\sdk\contentsafety\Azure.AI.ContentSafety\Azure.AI.ContentSafety.sln]
error : Missing project. Solution references a project which does not exist: D:\src\mengaims\azure-sdk-for-net\sdk\contentsafety\Azure.AI.ContentSafety\--. [D:\src\mengaims\azure-sdk-for-net\sdk\contentsafety\Azure.AI.ContentSafety\Azure.AI.ContentSafety.sln]

Is it the same case from your side? I'm confused with these errors, since I've double checked there is no invalid project reference in this solution file, and the CI build all look good. Besides I tried to search for some information but did not find the description of this script in https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md.
So that I'd like to ignore them, are you ok with it? Could you help approve if no other concern?

@mengaims mengaims enabled auto-merge (squash) June 5, 2023 13:51
@mengaims mengaims merged commit 1d3d91c into Azure:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengaims @azure-sdk @pallavit @heaths